Re: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies

From: Ilya Yanok
Date: Fri Sep 05 2008 - 06:18:20 EST


Hello,

Dan Williams wrote:
> Please also take a look at this cleanup patch that I will queue for
> .28. I think it makes things easier to read let me know if you
> disagree.
>

Look good for me. Hmm, actually I don't think that current version is so
hard to read...

Just one comment:

> - if (!next)
> + if (dep)
> + chan = dep->chan;
> + else
> return;
>

I don't like 'return' inside 'else'.

Regards, Ilya.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/