Re: [BUG] x86 kenel won't boot under Virtual PC

From: Jan Beulich
Date: Fri Sep 05 2008 - 12:15:43 EST


>--- a/include/asm-x86/nops.h
>+++ b/include/asm-x86/nops.h
>@@ -84,7 +84,7 @@
> #define ASM_NOP6 K7_NOP6
> #define ASM_NOP7 K7_NOP7
> #define ASM_NOP8 K7_NOP8
>-#elif defined(CONFIG_X86_P6_NOP)
>+/* #elif defined(CONFIG_X86_P6_NOP)
> #define ASM_NOP1 P6_NOP1
> #define ASM_NOP2 P6_NOP2
> #define ASM_NOP3 P6_NOP3
>@@ -93,6 +93,7 @@
> #define ASM_NOP6 P6_NOP6
> #define ASM_NOP7 P6_NOP7
> #define ASM_NOP8 P6_NOP8
>+*/
> #elif defined(CONFIG_X86_64)
> #define ASM_NOP1 K8_NOP1
> #define ASM_NOP2 K8_NOP2

I disagree here: If I configure a 686+ kernel, I expect these NOPs to be
that way (and to work). If you want to run on something that's not
compliant, you just shouldn't configure your kernel that way.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/