Re: [PATCH -mm] Fix dev_load() compilation again

[Andrew Morton]

On Fri, 05 Sep 2008 12:54:51 -0700
Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> Alexey Dobriyan wrote:
> > dev_load() doesn't exist if MODULES=n.
> 
> Hi,
> 
> in -next tree, this patch fixes the compilation error instead of
> my patch. So, there is a conflict.
> 
> commit 9b90dc7bc3079376567fc501e2e84751fa4040fd
> Author: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date:   Wed Aug 27 14:45:37 2008 +1000
> 
>     rr: build fix for remove CONFIG_KMOD from net
> 
>     Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> 

Give that there's already a fix in linux-next, I can't do anything here.

Rusty, the regression was introduced by

commit 4cb9da6ecc2b0e25056b45981239475f8509d59d
Author:     Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
AuthorDate: Wed Jul 9 10:28:42 2008 +0200
Commit:     Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
CommitDate: Tue Aug 26 10:19:47 2008 +1000

    remove CONFIG_KMOD from net
    
    Some code here depends on CONFIG_KMOD to not try to load
    protocol modules or similar, replace by CONFIG_MODULES
    where more than just request_module depends on CONFIG_KMOD
    and and also use try_then_request_module in ebtables.
    
    Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
    Cc: netdev@xxxxxxxxxxxxxxx
    Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Could you please take care of getting it fixed up?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/