Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for__u* typedef

[Alexey Dobriyan]

On Wed, Sep 10, 2008 at 03:55:04PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 10, 2008 at 04:14:50PM +0400, Alexey Dobriyan wrote:
> > On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > > --- a/include/linux/dlm_plock.h
> > > +++ b/include/linux/dlm_plock.h
> > 
> > > +#include <linux/types.h>
> > 
> > I'd say that unless you can demonstrate compilation breakage, these will
> > only slow down compilation.
> 
> Do you think that minor slow down is worse than dependence on the order of
> inclusion?

Since it compiles fine there is no such dependency.

Just removing externs from function prototypes makes compiles go faster for
_seconds_.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/