Re: [PATCH] include <linux/types.h> into linux/dlm_plock.h for__u* typedef

[David Woodhouse]

On Wed, 2008-09-10 at 16:14 +0400, Alexey Dobriyan wrote:
> On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > --- a/include/linux/dlm_plock.h
> > +++ b/include/linux/dlm_plock.h
> 
> > +#include <linux/types.h>
> 
> I'd say that unless you can demonstrate compilation breakage, these will
> only slow down compilation.

Not really. GCC notices the include guard pattern and won't even bother
to open the file the second and subsequent time it's included within a
compilation. I'd be astonished if you can measure any real slowdown at
all.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/