Re: [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFiCODEC and PMU

[Liam Girdwood]

On Wed, 2008-09-10 at 20:13 +0100, Mark Brown wrote:
> On Wed, Sep 10, 2008 at 07:47:01PM +0100, Liam Girdwood wrote:
> > On Wed, 2008-09-10 at 19:28 +0100, Mark Brown wrote:

> > > +EXPORT_SYMBOL_GPL(wm8400_notify_codec_reset);
> > > +
> 
> > I would probably rename this since it's really resetting the codec cache
> > and not resetting the codec.
> 
> The notify in the name was supposed to cover that (implying that it's
> notifying the core rather than actually doing the reset) but it's
> obviously not doing the job.  I think wm8400_reset_codec_reg_cache()
> should be obvious enough?
> 

Sounds good.

> > Fwiw, I've separated out the different wm8350 functions into separate
> > headers - Imho, It just makes it a little easier to read.
> 
> Yeah, I considered doing that but decided that it was more trouble than
> it was worth - the device has far fewer functions than the WM8350.

Wouldn't splitting out audio from power at least half the size of the
header. Imho probably making it easier to track down definitions per
function.

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/