Re: forcedeth: option to disable 100Hz timer (try 2)

From: Robert Hancock
Date: Wed Sep 10 2008 - 20:18:36 EST


Andrew Morton wrote:
On Tue, 9 Sep 2008 23:34:35 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx> wrote:

On some hardware no TX done interrupts are generated, thus special
100Hz timer interrupt is required to handle this situation properly.
Other device do not require that timer interrupt feature.

Forcedeth has a DEV_NEED_TIMERIRQ flag to mark the broken devices.
Unfortunately, nobody know the actual list of broken devices, so all
device has this flag on. Other problem, this flag is not user visible,
so the kernel recompilation is required to disable timer interrupts and
test a device.

This patch add a "disable_timerirq" option to disable interrupt timer mentioned above. This may be extremely useful for laptop users.

Why do you feel that the timer-based completions need to be disabled? Is it causing some problem?

100 unnecessary CPU wakeups per second imposes some power usage cost, especially on laptops with CPU C-states..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/