Re: [PATCH 3/3] OLPC: touchpad driver (take 2)

From: Dmitry Torokhov
Date: Thu Sep 11 2008 - 09:05:37 EST


On Thu, Sep 11, 2008 at 01:32:09AM -0400, Andres Salomon wrote:
>
> And here's the current touchpad driver after updating based upon your
> comments.
>

Looks good. Care to respin it all thogether based on the attribute
change I requested so I can be sure I'm applying the latest version of
everything? Ummm....

> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index 7bbea09..fff0253 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -96,6 +96,16 @@ config MOUSE_PS2_TOUCHKIT
>
> If unsure, say N.
>
> +config MOUSE_PS2_OLPC
> + bool "OLPC PS/2 mouse protocol extension"
> + depends on MOUSE_PS2 && OLPC

Are you sure it shoudl depend on OLPC? It looks like driver should
work on any box with PS/2 port. I understand that only OLPC has the
hardware installed but can this change?

Thanks!

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/