RE: [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return

From: Sosnowski, Maciej
Date: Fri Sep 12 2008 - 08:13:26 EST


Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
> ---
>
> drivers/dma/ioat_dma.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index bc8c6e3..1ef68b3 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -971,11 +971,9 @@ static struct ioat_desc_sw
> *ioat_dma_get_next_descriptor( switch
(ioat_chan->device->version) {
> case IOAT_VER_1_2:
> return ioat1_dma_get_next_descriptor(ioat_chan);
> - break;
> case IOAT_VER_2_0:
> case IOAT_VER_3_0:
> return ioat2_dma_get_next_descriptor(ioat_chan);
> - break;
> }
> return NULL;
> }

You are right. Thanks for pointing this out.

Acked-by: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/