Re: [RFC] CPUMASK: proposal for replacing cpumask_t

From: Rusty Russell
Date: Fri Sep 12 2008 - 18:03:14 EST


On Saturday 13 September 2008 00:28:56 Mike Travis wrote:
> Rusty Russell wrote:
> > I'm yet to be convinced that we really need to allocate cpumasks in any
> > fast paths. And if not, we should simply allocate them everywhere. I'd
> > rather see one #ifdef around a place where we can show a perf issue.
>
> Using a typedef came from Linus, and the idea is basically if NR_CPUS fits
> into a long, then it's carried as an array of one (ie., local variable).

Sure it's clever. ie. nice and confusing.

But do we have any code paths where we care? Unless we do, let's just keep it
simple...

Cheers,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/