Re: [PATCH 1/1] drivers/usb/host/pci-quirks.c: wait for EHCI handoff far too long in quirk_usb_disable_ehci()

[David Brownell]

On Tuesday 09 September 2008, Alan Stern wrote:
> > > 
> > > The delay in the current version of pci-quirks.c is 5 seconds,
> > > which I've cut down to 0.5 seconds.
> 
> > I guess it risks breaking someone else's system.  Or perhaps the number
> > was just grabbed out of the air.
> 
> As far as I know, it was indeed just grabbed out of the air.  The spec 
> specifically avoids giving an upper limit on how long to wait.
> 
> > Can we do a separate quirk just for that machine (and ones with the
> > same bug)?
> 
> My BIOS has the same bug.  I wouldn't mind seeing the delay reduced.

I'm fairly sure that someone's system needed more than 1/2 second.
And that going from 500 to 5000 was the obvious "add a zero" way
to get to a long-enough timeout.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/