Re: [PATCH] x86: io-apic - do not use KERN_DEBUG marker too much
From: Cyrill Gorcunov
Date: Sat Sep 13 2008 - 05:11:24 EST
[Yinghai Lu - Fri, Sep 12, 2008 at 12:57:21PM -0700]
...
| > 0 add_pin_to_irq: irq 15 --> apic 0 pin 15
| > IOAPIC[0]: Set routing entry (8-15 -> 0x3f -> IRQ 15 Mode:0 Active:0)
| > 8-16 8-17 8-18 8-19 8-20 8-21 8-22 8-23 (apicid-pin) not connected
| > 9-0 9-1 9-2 9-3 9-4 9-5 9-6 9-7 9-8 9-9 9-10 9-11 9-12 9-13 9-14 9-15
| > 9-16 9-17 9-18 9-19 9-20 9-21 9-22 9-23 (apicid-pin) not connected
| >
|
| only first one not connected at first, and ...
|
| why not just revert those two patches?
|
| YH
|
Ingo, Yinghai,
here is a quick fix for this.
Ingo - choose either use this patch or just _revert_ both
previous - i do accept any decision.
- Cyrill -
---
From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Subject: [PATCH] x86: io-apic - fix misplaced EOL in setup_IO_APIC_irqs
This issue is brought by mine commit
f5143bce9d424bd400da48b1c7a2bc6a24403ada.
Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
---
Index: linux-2.6.git/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/io_apic.c 2008-09-11 22:37:18.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/io_apic.c 2008-09-13 13:02:20.000000000 +0400
@@ -1541,6 +1541,11 @@ static void __init setup_IO_APIC_irqs(vo
pin);
continue;
}
+ if (notcon) {
+ apic_printk(APIC_VERBOSE,
+ " (apicid-pin) not connected\n");
+ notcon = 0;
+ }
irq = pin_2_irq(idx, apic, pin);
#ifdef CONFIG_X86_32
@@ -1552,11 +1557,6 @@ static void __init setup_IO_APIC_irqs(vo
setup_IO_APIC_irq(apic, pin, irq,
irq_trigger(idx), irq_polarity(idx));
}
- if (notcon) {
- apic_printk(APIC_VERBOSE,
- " (apicid-pin) not connected\n");
- notcon = 0;
- }
}
if (notcon)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/