Re: [PATCH] usbmon: fix tiny race exposed by the fastboot patches

From: Pete Zaitcev
Date: Sat Sep 13 2008 - 16:07:33 EST


On Sat, 13 Sep 2008 12:48:58 -0700, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> +++ b/drivers/usb/mon/mon_main.c
> @@ -361,12 +361,12 @@ static int __init mon_init(void)
> }
> // MOD_INC_USE_COUNT(which_module?);
>
> - usb_register_notify(&mon_nb);
>
> mutex_lock(&usb_bus_list_lock);
> list_for_each_entry (ubus, &usb_bus_list, bus_list) {
> mon_bus_init(ubus);
> }
> + usb_register_notify(&mon_nb);
> mutex_unlock(&usb_bus_list_lock);

Looks like the above does not add new deadlocks and does not
miss notifications, so ACK.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/