Re: wdt285: fix sparse warnings

[Wim Van Sebroeck]

Ben,

...
> @@ -141,13 +141,13 @@ static long watchdog_ioctl(struct file *
>  	switch (cmd) {
>  	case WDIOC_GETSUPPORT:
>  		ret = 0;
> -		if (copy_to_user((void *)arg, &ident, sizeof(ident)))
> +		if (copy_to_user((void __user *)arg, &ident, sizeof(ident)))
>  			ret = -EFAULT;
>  		break;
>  
...

Isn't it better to fix this like we did with the other watchdog drivers:
        void __user *argp = (void __user *)arg;
        int __user *p = argp;
	...
		if (copy_to_user(argp, &ident, sizeof(ident)))
	...

Regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/