Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

[Bodo Eggert]

Hisashi Hifumi <hifumi.hisashi@xxxxxxxxxxxxx> wrote:

> Protecting file->f_pos with a lock adds some overhead but I think we should
> fix this.
> I used seqlock to serialize the access to file->f_pos. This approach is
> similar to inode->i_size synchronization.
> 
> Comments?

> +             if (offset != file_pos_read(file))
> +                     file_pos_write(file, offset);

Maybe file_pos_write should do this check?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/