Re: [PATCH -next] blkdev.h: fix warnings when CONFIG_BLOCK=n

[Stephen Rothwell]

Hi Al,

On Tue, 16 Sep 2008 23:50:40 +0200 Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
>
> On Tue, Sep 16 2008, Randy.Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > 
> > Fix lots of build warnings when CONFIG_BLOCK=n:
> > 
> > linux-next-20080916/include/linux/blkdev.h:1093: warning: 'struct block_device' declared inside parameter list
> > linux-next-20080916/include/linux/blkdev.h:1093: warning: its scope is only this definition or declaration, which is probably not what you want
> > linux-next-20080916/include/linux/blkdev.h:1097: warning: 'struct gendisk' declared inside parameter list
> > linux-next-20080916/include/linux/blkdev.h:1105: warning: 'struct hd_geometry' declared inside parameter list
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > ---
> >  include/linux/blkdev.h |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > --- linux-next-20080916.orig/include/linux/blkdev.h
> > +++ linux-next-20080916/include/linux/blkdev.h
> > @@ -1089,6 +1089,10 @@ static inline long nr_blockdev_pages(voi
> >  
> >  #endif /* CONFIG_BLOCK */
> >  
> > +struct block_device;
> > +struct gendisk;
> > +struct hd_geometry;
> > +
> >  extern int __blkdev_driver_ioctl(struct block_device *, fmode_t, unsigned int,
> >  				 unsigned long);
> >  
> 
> Not sure which tree that build problem came from, it isn't from the
> block git tree.

I suspect this is caused by commit
44e95e9e8be95ec9ac6b0678e491883d99c0cfd8 ("beginning of methods
conversion") from your bdev tree. (the commit id is from next-20090816)

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature