Re: Regression in 2.6.27-rcX caused by commitbc19d6e0b74ef03a3baf035412c95192b54dfc6f

From: Henrique de Moraes Holschuh
Date: Tue Sep 16 2008 - 18:37:50 EST


On Tue, 16 Sep 2008, Michael Buesch wrote:
> But I don't know how to tell the rfkill subsystem about the states and

rfkill_force_state(). Must NOT be called from within atomic contextes,
something I haven't got around to find a proper way of fixing, and nobody
else seems to be on a rfkill coding frenzy right now.

> I'm still waiting for the sane rfkill API where we have three functions
> rfkill-allocate
> rfkill-hw-state-changed
> rfkill-free

I won't go on the rfkill-allocate/-free stuff, messing with that API means
you need to fix a lot of other people's drivers. But you have the
rfkill-hw-state-changed now, it is called rfkill_force_state(). The only
crap is that it cannot be called from atomic contexts.

> months ago, but is now deprecated it seems (but I don't know what it it
> replaced by) is just so really confusing.

Read Documentation/rfkill.txt. And the kernel-doc comments on rfkill.c.
The rfkill documentation was updated.

If you still have doubts after reading the stuff above, ask on
linux-wireless and CC me.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/