Re: [PATCH] rfkill: clarify usage of rfkill_force_state() andrfkill->get_state()

From: Johannes Berg
Date: Thu Sep 18 2008 - 13:52:56 EST


On Thu, 2008-09-18 at 19:32 +0200, Ivo van Doorn wrote:

> Ideal situation would indeed be that mac80211 registers a rfkill structure
> and listens to rfkill events. This would help drivers by only needing to
> register a rfkill structure for state-change events without any need for
> listeners.

Yup.

> I was considering such a patch some time ago, but needed to figure out
> how to work with the state-override capabilities (HW_BLOCK and SOFT_BLOCK)
> and didn't work on it any further since.

So make the struct part of the hw structure? Then drivers can just use
that to force hard events. Or actually, no, don't do this, make a new
mac80211 call:

ieee80211_inform_hardblocked(BLOCK/OPEN)

which makes sure we can also try to not associate in this case in the
future...

johannes

Attachment: signature.asc
Description: This is a digitally signed message part