Re: mmotm 2008-09-18-14-56 uploaded (olpc_battery build errors)

[Andrew Morton]

On Thu, 18 Sep 2008 15:42:18 -0700 (PDT)
"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:

> On Thu, 18 Sep 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> 
> > The mm-of-the-moment snapshot 2008-09-18-14-56 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > It contains the following patches against 2.6.27-rc6:
> 
> olpc_battery build fails with
> 
> mmotm-2008-0918-1456/drivers/power/olpc_battery.c: At top level:
> mmotm-2008-0918-1456/drivers/power/olpc_battery.c:363: error: unknown field 'owner' specified in initializer
> mmotm-2008-0918-1456/drivers/power/olpc_battery.c:363: warning: excess elements in struct initializer
> mmotm-2008-0918-1456/drivers/power/olpc_battery.c:363: warning: (near initialization for 'olpc_bat_eeprom.attr')
> make[3]: *** [drivers/power/olpc_battery.o] Error 1
> 

OK, x86-sysfs-kill-owner-field-from-attribute.patch is being a pain. 
The problem is that it tries to kill all `owner' instances and then
remove the `owner' field.

But of course new code keeps on turning up doing the wrong thing and
the build breaks and I hae to keep fixing it.

I'm going to do this:

--- a/include/linux/sysfs.h~x86-sysfs-kill-owner-field-from-attribute-fix-3
+++ a/include/linux/sysfs.h
@@ -27,9 +27,7 @@ struct module;
  */
 struct attribute {
 	const char		*name;
-#ifndef CONFIG_X86
 	struct module		*owner;
-#endif
 	mode_t			mode;
 };
 

Parag, once that patch is merged into mainline can you please send a second
one which cleans up any newly-added occurrences and which also nukes that field.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/