Re: [PATCH 2/4 v2] libata: Implement disk shock protection support

From: Tejun Heo
Date: Sat Sep 20 2008 - 00:50:47 EST


Elias Oltmanns wrote:
> Tejun Heo <htejun@xxxxxxxxx> wrote:
>> Elias Oltmanns wrote:
> Will do. By the way, it's just occurred to me that we really need to
> call complete_all() in ata_scsi_park_store(). So, thanks for making me
> think it all through once more.

Hmmm... just replied to the updated patch. complete_all() will
potentially overflow the done counter (which BTW is interface problem
in completion) why is it necessary? (probably best to continue on the
other thread).

Thanks.

--
tejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/