Re: [Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM

From: Dave Airlie
Date: Mon Sep 22 2008 - 03:00:06 EST


On Mon, Sep 22, 2008 at 9:51 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: "Rafael J. Wysocki" <rjw@xxxxxxx>
> Date: Sun, 21 Sep 2008 20:54:13 +0200 (CEST)
>
>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11382
>> Subject : e1000e: 2.6.27-rc1 corrupts EEPROM/NVM
>> Submitter : David Vrabel <david.vrabel@xxxxxxx>
>> Date : 2008-08-08 10:47 (45 days old)
>> References : http://marc.info/?l=linux-kernel&m=121819267211679&w=4
>> Handled-By : Christopher Li <chrisl@xxxxxxxxxx>
>
> Fixed by:
>
> commit 78566fecbb12a7616ae9a88b2ffbc8062c4a89e3
> Author: Christopher Li <chrisl@xxxxxxxxxx>
> Date: Fri Sep 5 14:04:05 2008 -0700
>
> e1000: prevent corruption of EEPROM/NVM
>
> Andrey reports e1000 corruption, and that a patch in vmware's ESX fixed
> it.
>
> The EEPROM corruption is triggered by concurrent access of the EEPROM
> read/write. Putting a lock around it solve the problem.
>

Just noticed I replied to davem and not to everyone.. so I did some
further hunting.

Okay so e1000e seems to have a problem in this area, that this *DOESN'T* fix.

I've reconstructed my boot timeline from message logs

Sep 3rd, I booted rawhide kernel 2.6.27-0.290.rc5.fc10.i686

I suspended/resume a few times in between with no issues.

Sep 8th I booted my own 2.6.27-rc5 kernel based from
ec0c15afb41fd9ad45b53468b60db50170e22346

This got a corrupted e1000e checksum and every kernel since has.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/