Re: [PATCH] AMD IOMMU: revert "x86, AMD IOMMU: honor iommu=off instead of amd_iommu=off"

[Joerg Roedel]

On Tue, Sep 23, 2008 at 12:25:23AM +0900, FUJITA Tomonori wrote:
> I don't think that users need to have iommu=calgary parameter to use
> calgary IOMMU by default. If you enable CONFIG_CALGARY_IOMMU,
> CALGARY_IOMMU_ENABLED_BY_DEFAULT is also enabled by default. If a
> kernel finds calgary IOMMU, the kernel uses it by default.
> 
> It's also consistent with how SWIOTLB. Users don't need iommu=soft
> parameter to enable SWIOTLB. A kernel enables SWIOTLB automatically
> when necessary.

Yes. The parameters are usefull if a user wants to enable a specific
IOMMU implementation. The user could be an IOMMU developer testing
changes in a special implementation the kernel would not choose by
default on his machine.
I like Ingo's idea here. Lets do boths, implementing iommu=$type to
force a specific iommu implementation and $(type)_iommu=off to disable
one.

> Well, this is the problem about the IOMMUs parameters. The IOMMUs
> parameters are too complicated for everyone.

Not so complicated that they can't be understood. But if you have a
proposal how the command line parameters for iommus may look like, send
it. I like join that discussion about the interface.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/