Re: [PATCH] UIO: Resend: Change driver name of uio_pdrv

[Hans J. Koch]

On Fri, Sep 19, 2008 at 09:40:34AM +0200, Uwe Kleine-KÃnig wrote:
> Hello Hans,
> 
> [Added Magnus Damm (= author of uio_pdrv_genirq) to Cc:]
> 
> On Thu, Sep 18, 2008 at 11:03:07PM +0200, Hans J. Koch wrote:
> > The patch below was already discussed and accepted:
> > http://lkml.org/lkml/2008/7/7/409
> > 
> > It somehow got lost (probably because I forgot it when I sent my queue
> > to Greg...). So, here it is again:
> > 
> > -------------8<------------------------
> > 
> > The generic UIO platform device driver should be given a unique driver ID and
> > not just "uio". This is especially important since we now have a similar driver
> > named uio_pdrv_genirq. Currently, there's no user of this driver in the
> > mainline kernel.
> I want to suggest to rename uio_pdrv_genirq to uio_genirq instead.  In
> my eyes this would be more clear.  IMHO the pdrv suffix doesn't yield
> more clearity because it is only used in a certain namespace---namely
> that of platform devices.  So e.g.
> 
> 	/sys/bus/platform/devices/uio_pdrv.0
> 
> isn't any better than
> 
> 	/sys/bus/platform/devices/uio.0

Well, I just want to avoid using the generic "uio" identifier for a
single driver. A sysfs entry like this last one looks like a kind of
"standard way" how a UIO platform device driver should be done. I'd like
to avoid that impression. It can be "uio_pdrv" or "uio_pdrv_genirq", but
there's no standard "uio" way of handling platform devices.

> 
> .  Looking at the name of other platform drivers using
> 
> 	git grep -E '_pdrv(_.*)?"' 
> 
> I get three false positives[1] and uio_pdrv_genirq (driver and some
> users in arch/sh/kernel/cpu/sh4a/setup-sh7343.c).  So the _pdrv suffix
> doesn't seem very common.

I don't really understand what you mean here.

> 
> Just my 0.02â

Thanks,
Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/