Re: [PATCH 1/2] corruption check: move the corruption checks intotheir own file

From: Ingo Molnar
Date: Tue Sep 23 2008 - 04:37:17 EST



* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> updated patch based on feedback from Randy that I should fix
> whitespace issues while moving code

but that's wrong. You should _never_ change code while moving it because
it's utterly unreviewable. Please split into two patches: first move the
code, then do the style cleanups in the target file.

also, could you please rename the new file to check.c - it's shorter and
we might check other things there too.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/