Re: [RFC PATCH -tip 0/4] x86: signal handler improvement

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> could we perhaps first finish unifying them into signal.c, and then 
> introduce __put_user_cerr() in signal_32/64.c?

i've got an API suggestion as well. Instead of:

-               err |= __put_user(UC_FP_XSTATE, &frame->uc.uc_flags);
+               __put_user_cerr(UC_FP_XSTATE, &frame->uc.uc_flags, err);

could you instead please make it:

+               __put_user_cerr(UC_FP_XSTATE, &frame->uc.uc_flags, &err);

i.e. pass in 'err' as a reference. This makes it clear to the casual 
reader, in a C calling convention sense, that there's a side-effect to 
'err'. [ There should be no change to the resulting code as 
__put_user_cerr() is a macro. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/