RE: [patch] x86, ptrace: void dopiness

From: Metzger, Markus T
Date: Tue Sep 23 2008 - 07:30:34 EST


>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@xxxxxxx]
>Sent: Montag, 22. September 2008 14:08
>To: Metzger, Markus T

>> The void-cast is intentional in both cases.
>>
>> I thought it a question of style, i.e. that we don't want void casts
>> just like we want NULL instead of 0.
>
>ok.
>
>But you could mark ds_release_bts() as a __must_check
>function, in that
>case the (void) has functional aspects as well: the kernel build will
>complain if a return value is ignored unintentionally.

Wouldn't every non-void function be __must_check?

regards,
markus.
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/