Re: [PATCH 2/2] corruption check: run the corruption checks from awork queue

[Ingo Molnar]

* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Mon, 22 Sep 2008 16:28:23 -0700 (PDT)
> "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
> 
> > On Mon, 22 Sep 2008, Arjan van de Ven wrote:
> > 
> > > eh a stray debug // snuck in; update attached
> > 
> > In that case, patch 1/2 contains "for(" and "while(".  :(
> > 
> 
> that's a dillema case.
> I'm just moving code around in patch 1/2; I personally consider it bad
> form to also change it at the same time.....
> 
> (and it confuses git change tracking)

correct. The right solution in this case (where code is moved around) to 
do a separate patch for the style errors Randy reported, once the code 
has been moved over.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/