Re: [PATCH 2.6.27-rc5 re-resubmit] Fix itimer/many thread hang.

From: Frank Mayhar
Date: Tue Sep 23 2008 - 18:57:43 EST


On Tue, 2008-09-23 at 17:59 +0400, Oleg Nesterov wrote:
> Looks like task_delta_exec() forgets to unlock rq.

Actually it shouldn't be locking rq. I failed to delete the lock.

> Confused. Unless I misread the patch, tgtimes->totals can be NULL
> on UP too?

Yeah. I totally messed up on this, too many things going on at once.
I've eliminated the SMP/UP split in sched_stats.h and pulled it all into
the three basic functions.

> (of course, this can't explain the crash)

I'll be investigating this in the morning (I'm at home today and without
a test box).
--
Frank Mayhar <fmayhar@xxxxxxxxxx>
Google, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/