Re: [PATCH git latest] drivers/scsi: fixing wrong comment beforenew_buffer_tape()

From: James Bottomley
Date: Fri Sep 26 2008 - 12:21:32 EST


On Fri, 2008-09-26 at 17:09 +0100, Alan Cox wrote:
> > > Looks true to me for the current versions of the code. In fact it is only
> > > ever called from the initialisation function that I can see so chunks of
> > > the code could simply go away as well as bits of the comment. Ditto the
> > > one in drivers/scsi/st.c
> > >
> > > Acked-by: Alan Cox <alan@xxxxxxxxxx>
> > >
> >
> > I am sorry I didn't quite understand. You mean it is true that caller
> > must hold os_scsi_tapes_lock?
>
> Sorry - I mean what you claim is true - that the comment is incorrect.

So, I think I'm missing a piece of this: There's no patch in this
thread (I presume it's lurking somewhere on lkml). Could someone repost
the proposed patch and copy the tape maintainer: Kai Makisara
<Kai.Makisara@xxxxxxxxxxx> to get his input?

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/