Re: [PATCH 3/3] Add timeout feature

[Takashi Sato]

Hi Ric and Christoph,

Ric Wheeler wrote:
> > > > And as with all previous posting I still fundamentally disagree about
> > > > the need of this functionality.  We don't need a timeout for freezing.
> > >
> > > I agree with Christoph here, I think that the timeout is unneeded.
> >
> > I think that your concern is that the freezer cannot recognize the occurrence
> > of a timeout and it continues the backup process and the backup data is
> > corrupted finally.
> > If the freezer can recognize it by the unfreeze ioctl's errono, will your concern
> > be solved?
> > If so, I will implement it.
> >
> > Cheers, Takashi
> I think that is certainly part a big part of my concern.
>
> Also note that the timeout seems to be quite low relative to say the standard timeout for a SCSI 
> device (30 seconds worst case).
>
> In general, I am quite supportive of the patch series and think that this is a great addition.

Thank you for your comments.
Christoph, do you have any comments about this solution?

If it's OK, I will change the freeze patch so that the unfreeze ioctl sets
ETIMEDOUT to errno when the timeout occurs.

Cheers, Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/