Re: Typo bug [Re: Linux 2.6.27-rc8]

From: Yinghai Lu
Date: Tue Sep 30 2008 - 17:35:25 EST


On Tue, Sep 30, 2008 at 12:59 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Yinghai Lu wrote:
>>
>> On Tue, Sep 30, 2008 at 11:47 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>>
>>> Ingo Molnar wrote:
>>>>>
>>>>> early_param("enble_mtrr_cleanup", enable_mtrr_cleanup_setup);
>>>>> ^^^^^^
>>>>>
>>>>> Nice ;)
>>>>
>>>> heh. Could you send a patch with a changelog please?
>>>
>>> These options are also named inconsistently with all other options.
>>>
>>> The standard way to name an boolean option is "foo" versus "nofoo", in
>>> this
>>> case, "mtrrcleanup" vs "nomtrrcleanup".
>>>
>> ok, we could change it...
>
> If we're fixing a typo anyway I'd suggest so. We know we're not breaking
> anyone's working setup...

mtrr_cleanup and no_mtrr_cleanup?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/