Re: [PATCH 3/3] x86: change MTRR_SANITIZER to def_bool y

From: J.A. MagallÃn
Date: Wed Oct 01 2008 - 03:24:42 EST


On Tue, 30 Sep 2008 23:46:54 -0700, "Yinghai Lu" <yinghai@xxxxxxxxxx> wrote:

> On Tue, Sep 30, 2008 at 11:36 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> >
> >> Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
> >>
> >> ---
> >> arch/x86/Kconfig | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > applied the patch below to tip/x86/mtrr, thanks Yinghai!
> >
> > (i'll wait for v2 of the mtrr parameter documentation patches.)
>
> mtrr-cleanup-debug, mtrr-clearnup, nomtrr-cleanup - v2 the 1/3 and
> 2/3 in series...
> or
> mtrr_cleanup_debug, mtrr_clearnup, nomtrr_cleanup -V?
> or
> mtrrcleanup_debug, mtrrclearnup, nomtrrcleanup -v1
>
> which one should we use ?
>

My vote ;)

mtrr-cleanup (mtrr-sanitize ?)
mtrr-nocleanup (probably better mtrr-asis or mtrr-default ?)
mtrr-debug

And you could get all parameters with dashes instead of underlines:

mtrr_chunk_size -> mtrr-chunk-size
mtrr_gran_size -> mtrr-gran-size
mtrr_spare_reg_nr -> mtrr-spare-regs (mtrr-spares ?)
disable_mtrr_trim -> mtrr-notrim (mtrr-trim needed for symmetry ?)

All begin with mtrr- and alpha ordering groups them together :).

--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2009.0 (Cooker) for i586
Linux 2.6.25-jam18 (gcc 4.3.1 20080626 (GCC) #1 SMP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/