Re: Block: Fix blk_start_queueing() so as not to process a stopped queue

From: Jens Axboe
Date: Wed Oct 01 2008 - 03:49:20 EST


On Wed, Oct 01 2008, Elias Oltmanns wrote:
> Especially since blk_start_queueing() is used as the unplug_fn() callback
> by the cfq scheduler, we'd better make it behave like a proper unplug
> function. That is to say, return immediately if the queue is stopped.
>
> Cc: stable <stable@xxxxxxxxxx>
> Signed-off-by: Elias Oltmanns <eo@xxxxxxxxxxxxxx>
> ---
> This is not a recent regression, so it might not be accepted as an rc
> fix. However, it most definitely is a bug and should go into a stable
> release. Applies to 2.6.27-rc8.

I don't think this is by far serious enough for -stable. Please let me
know what bad behaviour you observed due to this bug?

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/