Re: [PATCH] mm: unify shmem and tiny-shmem

[David Howells]

Hugh Dickins <hugh@xxxxxxxxxxx> wrote:

> That's much nicer than I'd been imagining, thanks Matt: I've no qualms
> about the few #ifdefs you're adding to mm/shmem.c, it does seem an
> outright improvement that you're bringing them together.

It's not an outright improvement.  shmem.o is still larger than tiny-shmem.o,
albeit not a lot; however, some embedded people really do count the bytes.

> This ifndef is the ugliest part of it: and looking into it, guess
> what, shmem_get_unmapped_area() hasn't been used since 2.6.20 -
> that's right, isn't it, David?

Ummm...  It seems to be.  I think it used to be used by SYSV SHM.  Certainly
deleting that function causes no link problems.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/