Re: [PATCH] ring_buffer: map to cpu not page

From: Steven Rostedt
Date: Thu Oct 02 2008 - 19:37:24 EST



On Thu, 2 Oct 2008, Steven Rostedt wrote:

>
> My original patch had a compile bug when NUMA was configured. I
> referenced cpu when it should have been cpu_buffer->cpu.
>
> Ingo quickly fixed this bug by replacing cpu with 'i' because that
> was the loop counter. Unfortunately, the 'i' was the counter of
> pages, not CPUs. This caused a crash when the number of pages allocated
> for the buffers exceeded the number of pages, which would usually

That should have been:

"when the number of pages allocated for the buffers exceeded the number
of cpus".

> be the case.
>

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/