Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG

[Linus Torvalds]

On Fri, 3 Oct 2008, Jiri Kosina wrote:
> 
> The debugging message is racy anyway with respect to accessing nvm_owner, 
> right? It should be done after the mutex has been succesfully acquired.

It's done that way on purpose - to see who _could_ be racing.

After the mutex, it could never trigger, because the mutex is the thing 
that guarantees non-racy-ness.

IOW, it's a debugging message just to see that the old bug (the "before 
the fix") really did happen. We can/will remove it, but I think people are 
still looking at the e1000e driver and probably want to see the paths that 
can cause problems.

Of course, it's entirely possible that we should remove it in mainline 
already, and just let the people inside intel/suse/xyzzy who are trying to 
reproduce it have it.

Jesse? Thomas?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/