Re: [PATCH] sdhci: 'scratch' may be used uninitialized

From: Ingo Molnar
Date: Mon Oct 06 2008 - 04:26:15 EST



* Pierre Ossman <drzeus@xxxxxxxxx> wrote:

> > Correct. Would you be interested in sending a patch for a
> > (default-off) debug feature that allows the disabling of all the gcc
> > annotations? That way we can do regular sweeps to determine whether
> > old annotations are still relevant on latest and greatest GCC.
>
> How would you find the ones that are no longer needed though?

ideally gcc should not emit _any_ bogus warning. Life is too short to
comb through crappy warnings and to keep in mind which ones are relevant
and which ones are not. compiler-intel.h does not make use of the
annotations for example.

> Perhaps we could make it so that uninitialized_var() itself emits a
> warning. That way you could turn that option on and check that you
> always have pairs of warnings.

ok - when CONFIG_CC_DEBUG_ALLOW_WARNINGS=y - and then the work flow
would be to go for single-occurance warnings and eliminate them (because
their annotation is moot).

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/