Re: RFC: banning device driver reserved resources from /dev/mem

[Maxim Levitsky]

Alan Cox wrote:
> > This patch adds, to the existing config option to restrict /dev/mem, the
> > reserved regions to the "banned from /dev/mem use" list, so now
> > both kernel memory and device-exclusive MMIO regions are banned.
>
> This breaks a whole class of diagnostic and debug tools which quite
> intentionally dump the MMIO register space of devices that are live.
>
> Plus it doesn't actually work - if I have /dev/mem open and mmapped you
> don't pull the pages from under me....
>
> The problem with the way this is going is the more you take from /dev/mem
> the sooner someone is forced to add /dev/mem-proper which undoes it all
> again so they can get work done.
>
> It's certainly a useful debug aid to know about such things but I don't
> believe it's something you should ban.

Exactly,

I think the proper solution is to make /dev/mem pure diagnostic tool.
Drivers should use /sys mappings of pci devices to access their iomem
, or even better they should not touch pci mappings
directly at all, but talk to kernel, and if xorg needs access 
to video memory it should talk to drm and get its mapping from there.


Best regards,
	Maxim Levitsky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/