Re: [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT

From: KOSAKI Motohiro
Date: Tue Oct 07 2008 - 07:26:20 EST


> > Honestly, I don't like that qemu specific feature insert into shmem core.
>
> I wouldn't say it's a qemu specific interface. While qemu would
> be the first user I would expect more in the future. It's a pretty
> obvious extension. In fact it nearly should be default, if the
> risk of breaking old applications wasn't too high.

hm, ok, i understand your intension.
however, I think following code isn't self describing.

addr = shmat(shmid, addr, SHM_MAP_HINT);

because HINT is too generic word.
I think we should find better word.

SHM_MAP_NO_FIXED ?


In addision, I still think current patch has too poor description and too
few comments.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/