Re: [BUG] SLOB's krealloc() seems bust

From: Peter Zijlstra
Date: Tue Oct 07 2008 - 14:11:51 EST


On Tue, 2008-10-07 at 10:57 -0700, Linus Torvalds wrote:

> Peter - can you check with that
>
> > if (slob_page(sp))
> > - return ((slob_t *)block - 1)->units + SLOB_UNIT;
> > + return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT;
>
> thing using
>
> - return ((slob_t *)block - 1)->units + SLOB_UNIT;
> + return ((slob_t *)block - 1)->units * SLOB_UNIT;
>
> instead?

went splat on the second run...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/