Re: [PATCH] x86: Add clflush before monitor for Intel 7400 series

From: H. Peter Anvin
Date: Tue Oct 07 2008 - 17:10:28 EST


Venki Pallipadi wrote:
For Intel 7400 series CPUs, the recommendation is to use a clflush on the
monitored address just before monitor and mwait pair [1]. This clflush makes
sure that there are no false wakeups from mwait when the monitored address
was recently written to.

[1] "MONITOR/MWAIT Recommendations for Intel Xeon Processor 7400 series"
section in specification update document of 7400 series
http://download.intel.com/design/xeon/specupdt/32033601.pdf

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>

This seems very expensive. It really makes me wonder if it wouldn't just be better to either declare monitor/mwait non-functional on this chip, or make sure that mwaits can handle false wakeups.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/