Re: [PATCH 3/3] Convert the UDP hash lock to RCU

From: Stephen Hemminger
Date: Tue Oct 07 2008 - 17:21:53 EST


On Tue, 07 Oct 2008 13:55:48 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Stephen Hemminger <shemminger@xxxxxxxxxx>
> Date: Tue, 7 Oct 2008 16:07:29 +0200
>
> > The idea of keeping chains short is the problem. That code should
> > just be pulled because it doesn't help that much, and also creates
> > bias on the port randomization.
>
> I have that patch from Vitaly Mayatskikh which does exactly this.
>
> I keep looking at it, but I can't bring myself to apply it since
> I'm not completely convinced.

Some one on a busy server should run it and measure the delta in hash chains.
I would, but don't run anything that has more than a few UDP's open.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/