Re: FRV/ARM unaligned access question

From: Harvey Harrison
Date: Wed Oct 08 2008 - 16:23:17 EST


On Wed, 2008-10-08 at 12:16 +0100, David Howells wrote:
> Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
>
> Switching to the packed struct algorithms also reduces the kernel size very
> slightly. Before:
>
> warthog>size vmlinux
> text data bss dec hex filename
> 2207836 66588 150189 2424613 24ff25 vmlinux
>
> After:
>
> warthog>size vmlinux
> text data bss dec hex filename
> 2207804 66588 150189 2424581 24ff05 vmlinux

Probably smaller as now the le values aren't being byteswapped anymore,
only the native endianess can use the struct version. Care to look at
the kernel size with the following instead?

From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Subject: [PATCH] frv: switch unaligned access to the packed-struct implementation

Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
---
include/asm-frv/unaligned.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-frv/unaligned.h b/include/asm-frv/unaligned.h
index 839a2fb..6c61c05 100644
--- a/include/asm-frv/unaligned.h
+++ b/include/asm-frv/unaligned.h
@@ -13,7 +13,7 @@
#define _ASM_UNALIGNED_H

#include <linux/unaligned/le_byteshift.h>
-#include <linux/unaligned/be_byteshift.h>
+#include <linux/unaligned/be_struct.h>
#include <linux/unaligned/generic.h>

#define get_unaligned __get_unaligned_be
--
1.6.0.2.471.g47a76



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/