Re: [PATCH] sky2: Fix recent WOL regression

From: Rafael J. Wysocki
Date: Wed Oct 08 2008 - 18:51:55 EST


On Friday, 3 of October 2008, Stephen Hemminger wrote:
> On Thu, 2 Oct 2008 23:39:33 +0200
> "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
>
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> >
> > sky2: Fix recent WOL regression
> >
> > Since dev->power.should_wakeup bit is used by the PCI core to
> > decide whether the device should wake up the system from sleep
> > states, set/unset this bit whenever WOL is enabled/disabled using
> > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > machine).
> >
> > Remove an open-coded reference to the standard PCI PM registers that
> > is not used any more.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > Reported-by: Tino Keitel <tino.keitel@xxxxxx>
> > ---
>
> Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
>
> Thanks for fixing this.

Can you please include this patch into your next push for Jeff?

It seems to have been overlooked.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/