Re: [PATCH] HPET: Remove the BKL.

[David John]

Andi Kleen wrote:
> David John <davidjon@xxxxxxxxxxx> writes:
> > @@ -586,7 +583,7 @@ static const struct file_operations hpet_fops = {
> >  	.llseek = no_llseek,
> >  	.read = hpet_read,
> >  	.poll = hpet_poll,
> > -	.ioctl = hpet_ioctl,
> > +	.unlocked_ioctl = hpet_ioctl,
>
> Did this actually compile without warning? unlocked_ioctl 
> has a different prototype than ioctl
>
> -Andi

Argg. I didn't check. :-[. Incidentally, this seems to have been done by 
Alan here: http://lkml.org/lkml/2008/5/22/350. Was the patch dropped later?

CC'd: Alan Cox

David.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/