Re: [PATCH] libata: Better timeout recovery

From: Alan Cox
Date: Fri Oct 10 2008 - 05:20:12 EST


> I'd very much prefer comments to be formatted like this:

Would you... ;)

> > + /* Can become DEBUG later */
> > + if (count)
> > + ata_port_printk(ap, KERN_WARNING,
> > + "drained %d bytes to clear DRQ.\n", count);
> > +
> > +}
>
> Presumably, you didn't intentionally leave a blank line before the
> closing brace.

Yes I did, it looked cleaner.

> Sorry if you were aware of all that and just sent the patch as a first
> draft in order to get comments on the actual code.

At the moment the main concern is the code quality - but you are right
I've not run the result through the style checker and probably should do
so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/