Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loadingfirmware with PCMCIA adapter

[Dave]

Andrey Borzenkov wrote:
> On Friday 10 October 2008, Dave wrote:
> > Thanks for identifying the problem. The Agere case looks good - a few suggestions for the Symbol case though:
>
> Updated patch attached
>
> >  
> > But you absolutely have to kfree(pda) here.
>
> Yes, I forgot; sorry.
>
> > Dan Williams wrote:
> > > maybe you should not use priv->pda_size but
> > > #define SYMBOL_PDA_SIZE 256 and use that for the hermes_read_pda()
> > > length just to ensure the patched code is functionally the same as
> > > before the patch.
> > Using fw->pda_size should be fine. The value comes from a const static, set to 0x100 for Symbol.
>
> Actually it allocated 512 byte before. Should it probably be set to 0x200?

You're right. pda_size is supposed to be the maximum size of the PDA (in bytes) that we expect with the firmware. It should be set to 0x200.

I've scanned the rest of the patch and it looks good.


Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/