Re: Looks broken to me: x86, cyrix: debug

From: Ingo Molnar
Date: Sat Oct 11 2008 - 16:59:34 EST



* Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> wrote:

> On Sat, 11 Oct 2008, Alan Cox wrote:
>
> > > +#define getCx86_old(reg) ({ outb((reg), 0x22); inb(0x23); })
> >
> > Doesn't expand to any kind of returned value.
>
> Well, actually it returns the value of the inb() expression -- cf the
> semantics of compound statements. The rest looks suspicious indeed.

indeed it's broken - will sort it out. It's all about breakage that has
been in this code since v2.6.20, see c6744955d0. Will likely revert the
whole thing.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/