Re: Looks broken to me: x86, cyrix: debug

From: Maciej W. Rozycki
Date: Sat Oct 11 2008 - 18:56:09 EST


On Sun, 12 Oct 2008, Willy Tarreau wrote:

> In fact the whole commit looks buggy to me as it simply reintroduces the
> old bug at several places. The correct way of accessing the registers is
> precisely through the inline functions and never through a macro due to
> the ordering problem.

Well, with some GCC extensions macros can be written such that ordering
is kept, but inline functions tend to be simpler and often more readable.

Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/