Re: [kerneloops] regression in 2.6.27 wrt "lock_page" and the"hwclock" program

From: Karel Zak
Date: Sun Oct 12 2008 - 15:46:58 EST


On Sun, Oct 05, 2008 at 10:27:42AM -0700, Andrew Morton wrote:
> On Sun, 5 Oct 2008 08:11:45 -0700 Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> >
> > static unsigned long
> > atomic(const char *name, unsigned long (*op)(unsigned long),
> > unsigned long arg)
> > {
> > unsigned long v;
> > __asm__ volatile ("cli");
> > v = (*op)(arg);
> > __asm__ volatile ("sti");
> > return v;
> > }
> >
> > looks like it (but only on 32 bit x86, not on 64 bit x86)
>
> I suspect this is new in hwclock?

since util-linux-2.9v, year 1999

> > (and yes someone really ought to fix hwclock; it's rather broken)
>
> well yeah. Recently broken?

9 years ago

Karel

--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/